This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Error refactor #168
Merged
Error refactor #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calyptobai
force-pushed
the
error-refactor
branch
2 times, most recently
from
432b474 to
4ad01fb
Compare
rsdy
approved these changes
Feb 14, 2023
oppiliappan
reviewed
Feb 14, 2023
oppiliappan
approved these changes
Feb 14, 2023
This allows us to use simple `Result<impl IntoResponse>` for webserver handler return types, and use plain `?`-based error handling.
calyptobai
force-pushed
the
error-refactor
branch
from
04f8548 to
a710745
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use simple
Result<impl IntoResponse>for webserver handler return types, and use plain?-based error handling, which correctly propagates HTTP status codes.