Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

corest
Copy link
Contributor

@corest corest commented Sep 19, 2023

No description provided.

@corest corest requested a review from ggordonhall September 19, 2023 11:22
Comment on lines +33 to +37
for member in $(echo ${members}); do
if [[ $member = $ACTOR ]]; then
echo "is-member=true" >> $GITHUB_OUTPUT
fi
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for member in $(echo ${members}); do
if [[ $member = $ACTOR ]]; then
echo "is-member=true" >> $GITHUB_OUTPUT
fi
done
for member in "${members[@]}"; do
[[ "$member" == "$ACTOR" ]] && echo "is-member=true" >> $GITHUB_OUTPUT
done

or we could change grep to use -F and -w.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to be explicit. Also this piece doesn't work in my shell

@corest corest merged commit 05fcffa into main Sep 19, 2023
@corest corest deleted the vol/fix-workflow-validation branch September 19, 2023 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants