This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Add buffer size configuration for reportinglib #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorblancoa
commented
Feb 15, 2019
jorblancoa
commented
- Read buffer size from neurodamus report.conf file
- Read buffer size from report.conf file
pramodk
approved these changes
Feb 22, 2019
|
@jorblancoa : looks good. one related thing : there is an existing command line option to change number of buffered steps: can you change this option to |
ferdonline
reviewed
Feb 25, 2019
| void set_report_buffer_size(int n) { | ||
| size_report_buffer = n; | ||
| #ifdef ENABLE_REPORTING | ||
| records_set_max_buffer_size_hint(size_report_buffer); |
There was a problem hiding this comment.
Suggested change
| records_set_max_buffer_size_hint(size_report_buffer); | |
| records_set_max_buffer_size_hint(size_report_buffer); |
| sscanf(raw_line, "\n%s %s %s %s %s %s %d %lf %lf %lf %d\n", report.name, report.target_name, | ||
| report.buffer_size = 4; //default size to 4 Mb | ||
| fgets(raw_line, MAX_FILEPATH_LEN, fp); | ||
| sscanf(raw_line, "\n%s %s %s %s %s %s %d %lf %lf %lf %d %d\n", report.name, report.target_name, |
There was a problem hiding this comment.
Suggested change
| sscanf(raw_line, "\n%s %s %s %s %s %s %d %lf %lf %lf %d %d\n", report.name, report.target_name, | |
| sscanf(raw_line, "\n%s %s %s %s %s %s %d %lf %lf %lf %d %d\n", report.name, report.target_name, |
There was a problem hiding this comment.
A couple of lines here got indented with tabs...
- report-buffer-size option with default of 4MB - Use command line buffer size if not default, otherwise use config file - Added aux method to check if the value of the command line is the default one - Fix identation issues
jorblancoa
force-pushed
the
reportinglib_buffer_size
branch
from
d31fbbc to
fc4f2de
Compare
pramodk
approved these changes
Feb 26, 2019
iomaganaris
pushed a commit
that referenced
this pull request
Mar 6, 2019
- Add buffer size configuration for reportinglib - Read buffer size from report.conf file - Add command line option for the report buffer size (4MB as default)
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
) - Add buffer size configuration for reportinglib - Read buffer size from report.conf file - Add command line option for the report buffer size (4MB as default) CoreNEURON Repo SHA: BlueBrain/CoreNeuron@680749a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.