This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Fix bug when spikes vector is empty #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohm314
suggested changes
Aug 12, 2019
ohm314
reviewed
Aug 12, 2019
jorblancoa
force-pushed
the
fix/sort_spikes
branch
from
a67cc49 to
8050f80
Compare
ohm314
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is reproduced when calling std::min/max_element() when spikevec_time is empty.
The use of those functions with an empty range returns the end iterator. Attempting to dereference this iterator is undefined behavior (segmentation fault in most cases).