Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

iomaganaris
Copy link
Contributor

No description provided.

…rn_fixed_step_minimal

- Moved block of code calling nrn_fixed_step_minimal from netcvode to fadvance_core
- Added instantiation and update of progressbar for it
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; have some minor questions/comments.

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and I like the overall improvement, but I had 2 minor questions.

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orena1
Copy link
Contributor

orena1 commented Feb 11, 2020

Related to #134

@ohm314 ohm314 merged commit b240992 into master Feb 12, 2020
@pramodk pramodk deleted the fix/gap_progressbar branch December 4, 2020 18:33
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
…lueBrain/CoreNeuron#254)

* Fixes issue with progressbar not instantiated when running sim with nrn_fixed_step_minimal
  - Moved block of code calling nrn_fixed_step_minimal from netcvode to fadvance_core
  - Added instantiation and update of progressbar for it
  - Update progressbar every 5 steps


CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b240992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants