This repository was archived by the owner on Mar 20, 2023. It is now read-only.
* move coreneuron toward full c++ #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fouriaux
commented
Mar 27, 2018
fouriaux
commented
- move coreneuron to coreneuron namespace
- fix test to comply to new changes
- fix c++ link with mod2c generated files
* move coreneuron to coreneuron namespace * fix test to comply to new changes * fix c++ link with mod2c generated files
…-skip-mpi-finalize command line option
… from inlinin (functions are not getting inlined with cpp)
The namespaces were not correctly nested.
pramodk
approved these changes
May 8, 2018
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
- coreneuron namespace added - change ivocvect vector compatibility and declarations - core_read and core_write to be out of coreneuron namespace - change public API of coreneuron to explose core_psolve - add pulbic header - kinderiv.h has prototype declaration for euler methods - changes to integrate with neurodamus: psolve_core renamed and added --skip-mpi-finalize command line option - OpenACC pragma annotation was missing for kernels using euler - cudaMemset wrong pointer (bug fix) - user provided flags should take precedence - change tests to comply to new changes - link with mod2c generated files CoreNEURON Repo SHA: BlueBrain/CoreNeuron@a0a760f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.