Automagic serialization #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
force-pushed
the
start_serialize
branch
2 times, most recently
from
7660c4b
to
7498eb8
Compare
|
What are we doing with broadcast? |
alkino
force-pushed
the
start_serialize
branch
2 times, most recently
from
57c6c15
to
c537faa
Compare
This was
linked to
issues
May 29, 2022
This was referenced May 29, 2022
if `val = boost::multi_array<...>`, `val` should have the same size than the new one
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
=========================================
Coverage ? 79.34%
=========================================
Files ? 65
Lines ? 3534
Branches ? 0
=========================================
Hits ? 2804
Misses ? 730
Partials ? 0 Continue to review full report at Codecov.
|
1uc
reviewed
Jun 14, 2022
|
|
||
| static constexpr size_t ndim = 1; | ||
| static constexpr size_t recursive_ndim = ndim + inspector<value_type>::recursive_ndim; | ||
| static constexpr bool is_trivially_copyable = true; |
There was a problem hiding this comment.
From the documentation I gather that this answers the question whether the inner type is trivially copyable? Don't you need the same thing as for std::vector<T>?
There was a problem hiding this comment.
We don't support recursivity with T*, I can try to add it
1uc
reviewed
Jun 15, 2022
1uc
approved these changes
Jun 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All types are supported