Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TagResultOutputMixin #13

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix TagResultOutputMixin #13

merged 1 commit into from
Jan 18, 2022

Conversation

adrien-berchet
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #13 (c5e3b73) into main (0775a96) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          711       719    +8     
  Branches       133       134    +1     
=========================================
+ Hits           711       719    +8     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data_validation_framework/target.py 100.00% <100.00%> (ø)
data_validation_framework/task.py 100.00% <100.00%> (ø)

@arnaudon
Copy link
Collaborator

What does it fix?

@adrien-berchet
Copy link
Member Author

If several tasks have this mixin the prefix can change unexpectedly in some specific cases. Now the target of the BaseValidationTask only uses self.result_path (which is computed when the task is instanciated, not when it is executed) instead of using the default prefix of the target class.

@arnaudon
Copy link
Collaborator

Ah I see, cool!

@adrien-berchet adrien-berchet merged commit 5cb935e into main Jan 18, 2022
@adrien-berchet adrien-berchet deleted the tag_output branch January 18, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants