Skip to content

Conversation

adrien-berchet
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds parallel execution capabilities to the dir-content-diff package, allowing for concurrent comparison of files using threads or processes. The implementation includes new configuration options for controlling the executor type and number of workers, while maintaining backward compatibility with the existing sequential execution mode.

  • Adds parallel execution support using ThreadPoolExecutor and ProcessPoolExecutor
  • Introduces new configuration parameters executor_type and max_workers to ComparisonConfig
  • Implements CLI options for controlling parallel execution behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
dir_content_diff/__init__.py Core implementation of parallel execution logic with helper functions for file chunking and comparison
dir_content_diff/cli/__init__.py CLI integration adding executor type and max workers command-line options
tests/test_parallel_execution.py Comprehensive test suite covering parallel execution functionality and edge cases
tests/test_base.py Enhanced existing tests to include logging verification for pick_comparator function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (90cf717) to head (a177e22).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          800       857   +57     
  Branches       133       146   +13     
=========================================
+ Hits           800       857   +57     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dir_content_diff/__init__.py 100.00% <100.00%> (ø)
dir_content_diff/cli/__init__.py 100.00% <100.00%> (ø)

@adrien-berchet adrien-berchet merged commit c0e7a83 into main Sep 13, 2025
9 checks passed
@adrien-berchet adrien-berchet deleted the parallel_diff branch September 13, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant