Skip to content
This repository was archived by the owner on Jan 28, 2022. It is now read-only.

Conversation

ohm314
Copy link
Contributor

@ohm314 ohm314 commented Apr 6, 2018

This benchmark module allows running and post-processing:

  • osu_latency
  • osu_bw
  • osu_allgather
  • osu_allgatherv

which are the most common benchmarks used for evaluation of interconnect performance.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.44% when pulling 1f084ca on osu_benchmark into d69aa69 on master.

@coveralls
Copy link

coveralls commented Apr 6, 2018

Coverage Status

Coverage decreased (-1.4%) to 84.137% when pulling a744997 on osu_benchmark into ae55a0c on master.

@tristan0x
Copy link
Member

If this one is ready to be reviewed, can you please rebase master branch first @ohm314 ?

@ohm314
Copy link
Contributor Author

ohm314 commented Apr 13, 2018

OK, I'm merging master into it (can rebasing be also done from the github web interface?). Otherwise this branch is ready to be merged back.

@tristan0x
Copy link
Member

osu was not referenced in setup.py. I added a unit-test so that it won't happen in the future.

If possible, please rebase instead of merging. It keeps the history much clearer.

@tristan0x tristan0x self-requested a review April 13, 2018 09:45
Copy link
Member

@tristan0x tristan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I am glad we have this one.

@tristan0x tristan0x merged commit 1f830c1 into master Apr 13, 2018
@tristan0x tristan0x deleted the osu_benchmark branch April 13, 2018 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants