This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Refactoring with ABC and properties #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: hpcbench/api.py tests/test_driver.py
ferdonline
force-pushed
the
abc_class_refactor
branch
from
b2b9c0d to
981d059
Compare
tristan0x
suggested changes
Jul 26, 2017
hpcbench/driver.py
Outdated
| if "no_exec" not in kwargs: | ||
| runs = dict() | ||
| for execution in self.benchmark.execution_matrix(): | ||
| print(self.benchmark.execution_matrix) |
There was a problem hiding this comment.
Can you please get rid of this print statement?
tests/test_driver.py
Outdated
| # FIXME add checks | ||
|
|
||
| def test_03_plot(self): | ||
| print(TestDriver.CAMPAIGN_PATH, os.getcwd()) |
There was a problem hiding this comment.
Can you please remove this print statement?
1 similar comment
|
Perfect ! Thank you @ferdonline |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.