Skip to content
This repository was archived by the owner on Jan 28, 2022. It is now read-only.

Use sinfo command to fill the network section automatically #210

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Use sinfo command to fill the network section automatically #210

merged 1 commit into from
Jun 5, 2018

Conversation

tristan0x
Copy link
Member

Use network.cluster = slurm in campaign to use sinfo to
deduce cluster details.

@tristan0x tristan0x requested a review from ohm314 June 5, 2018 09:53
@coveralls
Copy link

coveralls commented Jun 5, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 85.519% when pulling 2abfd7b on slurm-cluster into 97aab0f on master.

ohm314
ohm314 previously approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Use sinfo command to fill the network section automatically
2abfd7b 
Use `network.cluster = slurm` in campaign to use `sinfo` to
deduce cluster details.
ohm314
ohm314 approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@tristan0x tristan0x merged commit 5241af5 into master Jun 5, 2018
@tristan0x tristan0x deleted the slurm-cluster branch June 5, 2018 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ohm314 ohm314 ohm314 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristan0x @coveralls @ohm314