This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Fix/metrics driver #229
Merged
Fix/metrics driver #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2018 13:09
It uses several aspects of Enumerator already. Additonally did some basic renaming in ior.py to understand what is happening in the Extractor
Although not entirely clear why this is a fix. We cannot use the inherited report cached_property, which wraps the yaml report into a nameddict. @tristan0x might have the answer to that.
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricsDriver was not derived from Enumerator or Leaf. As a result the exception handling was broken. I made this class to now subclass Leaf. When doing this I noticed that the
self.reportcached property is causing the generated yaml files to be broken. I am not entirely sure why this is happening in this case, but I fixed it by loading in__call__()the yaml report without converting the read dict into anameddict.