This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Manage Spack specifications #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan0x
force-pushed
the
enh/spack
branch
5 times, most recently
from
e245572 to
7307719
Compare
ohm314
suggested changes
Oct 29, 2018
| test01: | ||
| type: stream | ||
| spack: | ||
| specs: |
There was a problem hiding this comment.
As mentioned also in the other repo. do we really need this additional level. It seems redundant, or do you think in the future we might have other spack functions that would go in there?
There was a problem hiding this comment.
Thank you for the feedback. I agree this extra level is a pain, but as I am not expert at spack, I prefered to leave space for future changes.
ohm314
approved these changes
Oct 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds capability to specify Spack specs in YAML that are installed before executing benchmarks.