Add explicit dependency on packaging

[tristan0x]

Do not assume version of setuptools installed and explicitly install packaging.

Fix #4

[coveralls]

Coverage remained the same at 89.777% when pulling d15f6e8 on fix/version_class into d68a48f on master.

[ferdonline]

If the only thing you need from "packaging" is the ability of read the version from GIT, give a look at setuptools_scm. It is more recent and has got a lot of attention.

[tristan0x]

Thank you Fernando. I will take a look at this. Best

…

On Aug 2, 2017 11:15 PM, "Fernando P." ***@***.***> wrote: ***@***.**** commented on this pull request. If the only thing you need from "packaging" is the ability of read the version from GIT, give a look at setuptools_scm. It is more recent and has got a lot of attention. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWd-3K6Iya1FRWJTHbN87VYbqInopDeks5sUObpgaJpZM4Oqts5> .

[ferdonline]

Actually I see now that you import "hpcbench" to extract the version.
I used to do that too, until I read this: https://packaging.python.org/guides/single-sourcing-package-version/
Anyway I would be interested in knowing what the Version object does.
Cheers

[tristan0x]

Hello Fernando, `packaging` provides an implementation for PEP 440[1] I use it to normalize the version set in hpcbench.__version__ `setuptools_scm` seems to remove the pain of maintaining manually the package version. I will definitely use it! Thank you for the pointer. [1] https://www.python.org/dev/peps/pep-0440/ Tristan Carel

…

On Thu, Aug 3, 2017 at 12:10 AM, Fernando P. ***@***.***> wrote: Actually I see now that you import "hpcbench" to extract the version. I used to do that too, until I read this: https://packaging.python.org/ guides/single-sourcing-package-version/ Anyway I would be interested in knowing what the Version object does. Cheers — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWd-5wb4xvhEQJy8boDtluJalurWbNLks5sUPPGgaJpZM4Oqts5> .