Add keywords to files during creation #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
reviewed
Jan 5, 2024
delta/plugins/elasticsearch/src/main/resources/contexts/indexing-metadata.json
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 5, 2024
| @@ -182,6 +182,9 @@ | |||
| } | |||
| } | |||
| }, | |||
| "_keywords": { | |||
There was a problem hiding this comment.
keywords.
Also:
- You will need a multi-field here to enable full text search properly
Flattenedcould be an option here, we have to be careful that when searching, the ES query does not fail because a keyword value does not exist but return an empty value
imsdu
reviewed
Jan 5, 2024
...src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/elasticsearch/client/QueryBuilder.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 5, 2024
...e/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/FormDataExtractor.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 5, 2024
...e/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/FormDataExtractor.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 5, 2024
...e/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/model/FileCommand.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
8 times, most recently
from
0f1e085
to
3566dc0
Compare
shinyhappydan
changed the title
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
from
3566dc0
to
d837d7c
Compare
dantb
reviewed
Jan 8, 2024
.../scala/ch/epfl/bluebrain/nexus/delta/plugins/elasticsearch/model/ResourcesSearchParams.scala
Outdated
Show resolved
Hide resolved
...e/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/FormDataExtractor.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/files/FilesSpec.scala
Show resolved
Hide resolved
...scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/model/FileSerializationSuite.scala
Show resolved
Hide resolved
| implicit val userMetadataCodec: Codec.AsObject[FileUserMetadata] = | ||
| deriveConfiguredCodec[FileUserMetadata] |
There was a problem hiding this comment.
I wonder if this should be treated as a leaf node and not have configured codecs? Since it really is just a Map[String, String] wrapper rather than a KG thing (which I assume the custom circe config is intended for)
There was a problem hiding this comment.
That sentence wasn't clear at all - just meant we don't want to accidentally map certain custom keys / values based on config like transformMemberNames
There was a problem hiding this comment.
I think with the tests we will know it's not accidentally mapped? I probably have in mind too much that there are other fields coming soon to this class. I'm not sure what a better version of this would look like
There was a problem hiding this comment.
Yeah, if we're testing mapped fields as the metadata fields. Just a regular Codec would work I think, without the configured part e.g. deriveCodec
imsdu
reviewed
Jan 9, 2024
.../scala/ch/epfl/bluebrain/nexus/delta/plugins/elasticsearch/model/ResourcesSearchParams.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
from
e364895
to
dc58b06
Compare
imsdu
reviewed
Jan 9, 2024
...ge/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/batch/BatchFiles.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 9, 2024
...age/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/model/FileState.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Jan 9, 2024
.../scala/ch/epfl/bluebrain/nexus/delta/plugins/elasticsearch/model/ResourcesSearchParams.scala
Outdated
Show resolved
Hide resolved
imsdu
approved these changes
Jan 9, 2024
dantb
approved these changes
Jan 12, 2024
...c/test/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/batch/BatchFilesSuite.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/files/BatchCopySpec.scala
Outdated
Show resolved
Hide resolved
.../src/test/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/generators/FileGen.scala
Outdated
Show resolved
Hide resolved
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
2 times, most recently
from
0500cf0
to
c987e9a
Compare
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
4 times, most recently
from
68c63d3
to
4a2dae7
Compare
…used to search for files. This is useful because currently users need to encode this type of information in the filename.
…e new attributes field backwards compatible
shinyhappydan
force-pushed
the
file-custom-metadata-create
branch
from
77e9718
to
7ab0340
Compare
imsdu
reviewed
Feb 1, 2024
...src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/storage/files/model/FileRejection.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4512