Handle S3 access error gracefully with 403 #4954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4887
To test this using localstack would require adding IAM to our container setup, then creating and setting up users with the desired permissions via the SDK. With all that setup, it might be inconsistent with the real S3 anyway. I thought it best to test manually instead by:
S3StorageSpec
, see what file upload failures look likeIn the end we now return 403 with