Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation changes for "inline" scopmath solvers. #859

Merged
merged 3 commits into from
May 12, 2022

Conversation

olupton
Copy link
Contributor

@olupton olupton commented May 4, 2022

Analogue of BlueBrain/mod2c#81, goes with BlueBrain/CoreNeuron#809.

Also:

  • Support setting the CVF_BRANCH variable via CI_BRANCHES syntax in a PR description or explicitly when launching the pipeline from GitLab
  • Add restart_block, fmt_line and fmt_start_block methods for code generation.

CI_BRANCHES:CORENEURON_BRANCH=olupton/scopmath-inline,SPACK_BRANCH=develop

@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot

This comment was marked as outdated.

@olupton olupton closed this May 11, 2022
@olupton olupton reopened this May 11, 2022
@bbpbuildbot

This comment was marked as outdated.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #54169 (:white_check_mark:) have been uploaded here!

Status and direct links:

@olupton olupton marked this pull request as ready for review May 11, 2022 15:08
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I assumed it's mostly reorganization of the code)

.gitlab-ci.yml Show resolved Hide resolved
@olupton olupton merged commit a237926 into master May 12, 2022
@olupton olupton deleted the olupton/scopmath-inline branch May 12, 2022 16:19
iomaganaris pushed a commit that referenced this pull request May 13, 2022
* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.
iomaganaris pushed a commit that referenced this pull request May 13, 2022
* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.
iomaganaris pushed a commit that referenced this pull request May 13, 2022
* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.
iomaganaris pushed a commit that referenced this pull request May 13, 2022
* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.
iomaganaris added a commit that referenced this pull request May 17, 2022
#868)

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.

Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris added a commit that referenced this pull request Sep 15, 2022
#868)

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.

Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris added a commit that referenced this pull request Sep 15, 2022
#868)

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.

Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants