-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code generation changes for "inline" scopmath solvers. #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
olupton
force-pushed
the
olupton/scopmath-inline
branch
from
May 6, 2022 16:43
2dfcfbd
to
5058dbf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
olupton
force-pushed
the
olupton/scopmath-inline
branch
from
May 9, 2022 09:19
19f78c8
to
b71a45b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- Add CodePrinter::restart_block method.
olupton
force-pushed
the
olupton/scopmath-inline
branch
from
May 11, 2022 14:29
0e445dd
to
c06f331
Compare
Logfiles from GitLab pipeline #54169 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (I assumed it's mostly reorganization of the code)
This was referenced May 11, 2022
iomaganaris
pushed a commit
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
pushed a commit
that referenced
this pull request
May 13, 2022
* Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable.
iomaganaris
added a commit
that referenced
this pull request
May 17, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris
added a commit
that referenced
this pull request
Sep 15, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris
added a commit
that referenced
this pull request
Sep 15, 2022
#868) * Use named structs instead of functions, pass instances to solvers. * Goes with BlueBrain/CoreNeuron#809. * Add fmt_line, fmt_start_block and restart_block methods to CodePrinter. * gitlab-ci: support CVF_BRANCH variable. Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogue of BlueBrain/mod2c#81, goes with BlueBrain/CoreNeuron#809.
Also:
CVF_BRANCH
variable viaCI_BRANCHES
syntax in a PR description or explicitly when launching the pipeline from GitLabrestart_block
,fmt_line
andfmt_start_block
methods for code generation.CI_BRANCHES:CORENEURON_BRANCH=olupton/scopmath-inline,SPACK_BRANCH=develop