Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM] Cherry-pick scopmath commit from master #868

Merged
merged 1 commit into from
May 17, 2022

Conversation

iomaganaris
Copy link
Contributor

  • Cherry-picks a237926 from master to fix CI issues with CoreNEURON master
  • When we rebase llvm on master again we will have to fix some conflicts regarding restart_block function in CodePrinter. After fixing those we should be able to squash the existing commit and others whose names start with CP-<PR_ID>

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.
@iomaganaris iomaganaris requested a review from pramodk May 13, 2022 13:18
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #54855 (:no_entry:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iomaganaris iomaganaris merged commit fe4a2dc into llvm May 17, 2022
@iomaganaris iomaganaris deleted the magkanar/llvm_scopemath branch May 17, 2022 16:23
iomaganaris added a commit that referenced this pull request Sep 15, 2022
#868)

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.

Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
iomaganaris added a commit that referenced this pull request Sep 15, 2022
#868)

* Use named structs instead of functions, pass instances to solvers.
* Goes with BlueBrain/CoreNeuron#809.
* Add fmt_line, fmt_start_block and restart_block methods to CodePrinter.
* gitlab-ci: support CVF_BRANCH variable.

Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants