Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 Added Portuguese translation (Resources.pt.resx) to Resources.resx #16

Closed
wants to merge 1 commit into from
Closed

Conversation

Joaolfelicio
Copy link

@Joaolfelicio Joaolfelicio commented Oct 3, 2020

#12

@alxnull
Copy link
Member

alxnull commented Oct 4, 2020

Hi @Joaolfelicio,

First, thank you very much for your effort in helping to translate this project 👍. Unfortunately, someone already contributed a Portuguese translation shortly before you (#14). Since I certainly cannot merge both translations, I'm sorry to say that I cannot merge this PR.
If you still would like to contribute, there are two options: Review the existing Portuguese translation and open a new PR if you find typos/ possible improvements or help translating another of my projects still missing a Portuguese translation (I'll open that for Hacktoberfest soon and can directly assign you for Portuguese if you wish).

@Joaolfelicio
Copy link
Author

Hello @alxnull
Sorry, was not aware of the Portuguese translation until after sending the PR.
Yes, please assign it to me and I will translate it, thank you!

@alxnull alxnull closed this Oct 4, 2020
@Joaolfelicio
Copy link
Author

@alxnull BTW, would you mind assigning the label "hacktoberfest-accepted" to my PR?
Will take a look into the PT translation to see if I can spot any typo.
Thanks.

@alxnull
Copy link
Member

alxnull commented Oct 4, 2020

@Joaolfelicio Sure, I'll do, would you mind starring this repo in exchange? ;)

I'll also inform you about the other translation task soon.

@alxnull
Copy link
Member

alxnull commented Oct 4, 2020

@Joaolfelicio As promised, here's the issue on the other repo Bluegrams/ScreenRuler#14. Just comment there to assign yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants