Publish StarDict files

[BoboTiG]

--convert: Generate dict-LOCALE.df

And not dict-LOCALE-LOCALE.df.

• Related to Output to other formats #409
• Tests added/updated.
• ./check.sh run and eventual issues fixed.
• Updated CONTRIBUTORS.md, if not already done in the past.

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.05%.

Quality metrics	Before	After	Change
Complexity	21.22 😞	21.22 😞	0.00
Method Length	65.77 🙂	65.59 🙂	-0.18 👍
Working memory	13.44 😞	13.44 😞	0.00
Quality	52.74% 🙂	52.79% 🙂	0.05% 👍

Other metrics	Before	After	Change
Lines	413	413	0

Changed files	Quality Before	Quality After	Quality Change
tests/test_3_convert.py	60.49% 🙂	60.49% 🙂	0.00%
wikidict/convert.py	51.87% 🙂	51.91% 🙂	0.04% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
wikidict/convert.py	KoboFormat.save_html	69 ⛔	324 ⛔	20 ⛔	7.93% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/convert.py	DFFormat.process	8 ⭐	134 😞	13 😞	51.64% 🙂	Try splitting into smaller methods. Extract out complex expressions
tests/test_3_convert.py	test_simple	0 ⭐	98 🙂	35 ⛔	53.27% 🙂	Extract out complex expressions
tests/test_3_convert.py	test_generate_dict	0 ⭐	109 🙂	17 ⛔	57.81% 🙂	Extract out complex expressions
wikidict/convert.py	KoboFormat.save	2 ⭐	185 😞	9 🙂	59.66% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

[lasconic]

ifo.dict.dz ? really ?
I used

python3 main.py ../ebook-reader-dict/data/fr/dict-fr.df dict-fr.ifo

and I got

dict-fr.dict	dict-fr.idx	dict-fr.ifo	dict-fr.syn

[BoboTiG]

And I got dict.dz and no .syn :)

[BoboTiG]

Maybe local results are bad (for whatever reason). But ideally pyglossary generates the final Zip, it would ease things.

[BoboTiG]

We could do something like:

$ pyglossary --read-format Dictfile --write-format Stardict --no-progress-bar --no-color data/${{ matrix.locale }}/dict-${{ matrix.locale }}.df dict-data.ifo
$ zip dict-${{ matrix.locale }}.zip dict-data.*

But I am not sure of the Zip filenames then. Do you know if names are important or just the file extension maybe?