Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on "empty recycle bin" #2534

Closed
loki-core opened this issue Feb 3, 2021 · 2 comments
Closed

Error on "empty recycle bin" #2534

loki-core opened this issue Feb 3, 2021 · 2 comments

Comments

@loki-core
Copy link

Describe the bug
It is not possible to empty the trash in the admin area.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Delete a page, a book or a shelf
  2. Go to Settings -> Maintenance -> Open Recycle bin
  3. Click on empty recycle bin or remove an item in the list

Screenshots
If applicable, add screenshots to help explain your problem.
image

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings):BookStack v0.31.5
  • Hosting Method (Nginx/Apache/Docker): Docker

Additional context
Log:
[2021-02-01 21:10:49] production.ERROR: Return value of BookStack\Entities\Tools\TrashCan::destroyEntity() must be of the type int, none returned {"userId":1,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Return value of BookStack\\Entities\\Tools\\TrashCan::destroyEntity() must be of the type int, none returned at /var/www/html/app/Entities/Tools/TrashCan.php:304) #19 /var/www/html/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(BookStack\\Http\\Request)) #20 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(171): Illuminate\\View\\Middleware\\ShareErrorsFromSession->handle(Object(BookStack\\Http\\Request), Object(Closure)) [2021-02-01 21:11:08] production.ERROR: Return value of BookStack\Entities\Tools\TrashCan::destroyEntity() must be of the type int, none returned {"userId":1,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Return value of BookStack\\Entities\\Tools\\TrashCan::destroyEntity() must be of the type int, none returned at /var/www/html/app/Entities/Tools/TrashCan.php:304) #18 /var/www/html/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(BookStack\\Http\\Request)) #19 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(171): Illuminate\\View\\Middleware\\ShareErrorsFromSession->handle(Object(BookStack\\Http\\Request), Object(Closure)) [2021-02-01 21:11:57] production.ERROR: Return value of BookStack\Entities\Tools\TrashCan::destroyEntity() must be of the type int, none returned {"userId":1,"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Return value of BookStack\\Entities\\Tools\\TrashCan::destroyEntity() must be of the type int, none returned at /var/www/html/app/Entities/Tools/TrashCan.php:304)

@loki-core
Copy link
Author

Possible pull request #2530

@ssddanbrown
Copy link
Member

Thanks for reporting @loki-core, This has been addressed and covered with testing within cc5d0ef, 7843d8f & 61a911d and will be part of the next patch release due within the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants