New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem highligth markdown #296

Closed
ElGranLoky opened this Issue Feb 2, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@ElGranLoky

ElGranLoky commented Feb 2, 2017

  • BookStack Version: 0.14.1
  • PHP Version:
    php -v
    PHP 5.6.30 (cli) (built: Jan 19 2017 07:57:06)
    Copyright (c) 1997-2016 The PHP Group
    Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
Expected Behavior

When i use highlight in the markdown lang, i dont have the correct code for the highligth for example:

```sh
yum -y install vim
```

```diff
- server 0.centos.pool.ntp.org iburst
- server 1.centos.pool.ntp.org iburst
- server 2.centos.pool.ntp.org iburst
- server 3.centos.pool.ntp.org iburst
+ #server 0.centos.pool.ntp.org iburst
+ #server 1.centos.pool.ntp.org iburst
+ #server 2.centos.pool.ntp.org iburst
+ #server 3.centos.pool.ntp.org iburst
```

Actual Behavior

I get this code:

<pre id="bkmrk-yum--y-install-vim" class="hljs nginx"><code><span class="hljs-title">yum</span> -y install vim�
</code></pre>
<pre id="bkmrk---server-0.centos.po" class="hljs css"><code class="lang-diff"><span class="hljs-tag">-</span> <span class="hljs-tag">server</span> 0<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
<span class="hljs-tag">-</span> <span class="hljs-tag">server</span> 1<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
<span class="hljs-tag">-</span> <span class="hljs-tag">server</span> 2<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
<span class="hljs-tag">-</span> <span class="hljs-tag">server</span> 3<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
+ <span class="hljs-id">#server</span> 0<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
+ <span class="hljs-id">#server</span> 1<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
+ <span class="hljs-id">#server</span> 2<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
+ <span class="hljs-id">#server</span> 3<span class="hljs-class">.centos</span><span class="hljs-class">.pool</span><span class="hljs-class">.ntp</span><span class="hljs-class">.org</span> <span class="hljs-tag">iburst</span>
</code></pre>

Kdecherf added a commit to Kdecherf/BookStack that referenced this issue Apr 6, 2017

views: fix support of language in markdown fenced code block
Fixes #296

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.17 milestone Jul 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment