New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached items are not deleting in single click #884

Closed
durgasravani23 opened this Issue Jun 10, 2018 · 0 comments

Comments

3 participants
@durgasravani23

durgasravani23 commented Jun 10, 2018

For Bug Reports

  • BookStack Version: v0.22.0
  • PHP Version: 7.x
  • MySQL Version: 10.x
Expected Behavior

Clicking on delete icon should delete the file.

Current Behavior

File is getting deleted on second click on the delete icon.

Steps to Reproduce
  1. Open a page.
  2. Upload one or more files (any file type)
  3. Go to attached items tab
  4. Click on the delete icon (x) - File will not be deleted.
  5. Click on the delete icon (x) again - File will be deleted.

@Abijeet Abijeet added the Bug label Jun 17, 2018

Abijeet added a commit that referenced this issue Jun 17, 2018

Fixes issue with having to click the delete icon for attachment twice.
Fixes #884

This is happening because -

Due to the limitations of modern JavaScript (and the abandonment of Object.observe), Vue cannot detect property addition or deletion. Since Vue performs the getter/setter conversion process during instance initialization, a property must be present in the data object in order for Vue to convert it and make it reactive.

Source: https://vuejs.org/v2/guide/reactivity.html

Also added padding to the icons in the attachment section.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.23.0 milestone Jun 17, 2018

@Abijeet Abijeet closed this in #892 Jun 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment