Feature - allow toggling between grid and list view in shelf view (shelves.show) #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssddanbrown
added a commit
that referenced
this pull request
Apr 10, 2020
- Separated books-list and shelf-show view types to be saved separately. During review of #1755
|
Apologies for my late review and thanks for offering this pull request @philjak. Have now added tests to cover and merged to be part of the next feature release. Only thing I changed was to separate the setting out to be stored separately from that of the books-list view, Just for users that want to keep these views different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the list/grid view toggle button to the shelves.show view. This button is already available in the shelves.index as well as in books.index.
This allows users to use the desired view even when looking directly into a shelf.