Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2020

There is issue with viewing all the export list.

Step to reproduce the issue:

  1. Login to bookstack.
  2. Open any book or page.
  3. Click on export.
  4. There are three list in the dropdown but only two can be visible third one is hidden.

There is issue with viewing all the export list
@ssddanbrown
Copy link
Member

Thanks for attempting a fix for this @shubhamosmosys.

Could height: 100% be used instead of a fixed px height please? The use of 1000px results in the sidebar increasing the page height on smaller pages. Additionally, could this be applied to the .tri-layout-left-contents, .tri-layout-right-contents rule at line 267 within the same file since this would apply to both of the sidebars and saves us an extra rule being defined.

@ghost
Copy link
Author

ghost commented Dec 18, 2020

Hi @ssddanbrown,
We can't use height: 100% because that will violate the sticky behaviour of .tri-layout-left-contents, and .tri-layout-right-contents on scrolling page.
On scrolling page, left and right side content should be sticky in nature until they get scroll.

Issue can be seen below:
image

Expected Behaviour on scrolling page:
image

Also since we can have many pages inside the book. So, the size of .tri-layout-left-contents should not be fixed.
Hence, we're fixing only .tri-layout-right-contents size.

@ssddanbrown
Copy link
Member

Hi @shubhamosmosys,

With a quick test in chrome and firefox, adding height: 100% about here did not affect the sticky behaviour at all. Are you testing in a different browser or perhaps testing the style elsewhere?

Also since we can have many pages inside the book. So, the size of .tri-layout-left-contents should not be fixed.
Hence, we're fixing only .tri-layout-right-contents size.

Both of the sidebars have the potential to be taller or shorter than the viewport. In that regard I don't know why we need to treat them differently.

@ghost
Copy link
Author

ghost commented Dec 21, 2020

Hi @ssddanbrown,
Thanks for the suggestion. Adding height:100% is working fine.
Updated the PR.

@ssddanbrown ssddanbrown added this to the v0.31.0 milestone Jan 2, 2021
@ssddanbrown
Copy link
Member

Thanks @shubhamosmosys, Will merge in for the next release.

@ssddanbrown ssddanbrown merged commit e6ea53b into BookStackApp:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant