Skip to content

Additional copy/clone abilities #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2021
Merged

Additional copy/clone abilities #3118

merged 5 commits into from
Dec 20, 2021

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Dec 19, 2021

As per definition at #1123 (comment).

Todo

  • Role copying
  • Chapter copying
  • Book copying
  • Testing
  • Update views to highlight considerations below?

Considerations

  • Permissions will not be copied.
  • Page Attachments will not be copied.
  • Page images will not be updated nor will their relation to pages be updated.
  • Copied content owner will be the copier.
  • Due to the above, copied content could be visible to a different set of people.

Related to #1123

- Copies via loading in model on create view.
- Updated role views while editing to bring up to similar format as
  that used for more modern app areas.
- Added tests to cover.

Related to #1123
Fundemental refactor for planned additional clone operations.
No behaviour change intended in this commit.
Builds upon page clone work. Takes permissions into account to decide
if child pages should be copied.
Show to the user when copying stuff to highlight important things such
as what's not copied or change in permissions.
@ssddanbrown ssddanbrown merged commit 21f2a70 into master Dec 20, 2021
@ssddanbrown ssddanbrown deleted the copy_stuff branch December 20, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant