Support new lines for book/chapter descriptions + fix tests #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 14, 2017 16:05
Avoid ignoring new lines when renderring the book/chapter descriptions on their respective detailed views.
|
Victory! 🎉 |
clemblanco
changed the title
|
@ClayMM Thank you very much for this pull request, Never even thought about multi-line descriptions. I did make a couple of tweaks to the code. Thanks for trying to fix my LDAP testing, I altered this recently in a way that does not require to have LDAP loaded so I have removed the travis changes to keep builds speedy. Also, The Change to the titles allowed user HTML Injection so I have added some additional escaping. Both of these changes can be seen here: 21247e1 Thanks again! Will be part of the next bugfix release, v0.17.4, due in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid ignoring new lines when renderring the book/chapter descriptions on their respective detailed views.
And fixing the tests too (LDAP needs to be installed before running the LDAP tests).