Skip to content

Notifications: User language for notification text #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2023
Merged

Notifications: User language for notification text #4497

merged 3 commits into from
Sep 2, 2023

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Sep 1, 2023 •
edited
Loading

For #4480.

Todo

  • Add test case to cover.
  • Update notifications to use user language preference.
  • Test what occurs when a non-expected language preference exists.
  • Test bottom text, that's not controlled in notification class.
    • Check this for user invites (and other existing notifications) too. Likely need to add system in other places to properly pass notifications.

@ssddanbrown ssddanbrown added this to the v23.08.1 milestone Sep 1, 2023
@ssddanbrown ssddanbrown self-assigned this Sep 1, 2023
@ssddanbrown
Notifications: Aligned how user language is used
3847a76 
- This ensures content notifications are not translated to receiver
  language.
- This adds actual plaintext support for content notifications (Was
  previously just HTML as text view).
- Shares same base class across all mail notifications.
- Also cleaned up existing notification classes.

Future cleanup requested via #4501
@ssddanbrown
Testing: Added entity decode flag and phpunit env option
a720b37 
- Passed decode flags to provide consistent behaviour across PHP
  versions during testing.
- Added env option to prevent local option taking action in PHPunit
  tests.
@ssddanbrown ssddanbrown merged commit 1cd19c7 into development Sep 2, 2023
@ssddanbrown ssddanbrown deleted the notification_language branch September 2, 2023 14:47
@ssddanbrown ssddanbrown mentioned this pull request Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
🐛 Bug 🏭 Back-End
Milestone
v23.08.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ssddanbrown