-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Open in Explorer" for playlists #61
Conversation
Build listFix_2.5.1-[PR61]-9. |
a328b0a
to
3100aed
Compare
3100aed
to
7823dc4
Compare
Build: listFix_2.5.1-[PR61]-10.exe |
You are really moving along so fast, it's hard to catch up with you. 😳 Again, I need to know whether you want me to install and test the builds in the order which you release them? Sometimes I am not ready to test the first build before the release of newer builds. A case in point, for example, given below in order of the listFix() current releases:
Do we jump straight to 3? I think we should establish some kind of release protocol for this, do you agree, or maybe such already exists one already for situations similar to this? |
It's really fantastic to read that you have already added the "Open in Explorer" enhancement. 👍 Thank you! Hopefully, the current build can be tested today. Looking forward to it, very much. |
Created Release Procedure in PR #62. |
listFix_2.5.1-[PR61]-10
—— 5.1 In order to standardise, shall we consider to rather call the playlist repair pane the "Playlist Editor" from now on — or do you perhaps want to standardise on something else? In fact, I think this pane should get a title at the top? What do you think? Clear and precise naming is important for so many usage and support reasons. —— 5.2 The tab-titles of the all 12 playlists, now open in the "Playlist Editor", were corrupted as before — exhibiting what appears to be superimposed labels/text. —— 5.3 Each of the labels now displays the tab-closer "x" visibly, where it should. Clicking the "x", closes the tab properly. —— 5.4 A right mouse click, activates the tab, but nothing else happens. Is this action not supposed to evoke the tab context menu, which controls certain operations to be performed on it, such as: close the tab, close all tabs, close other tabs, and more? —— 5.5 The command to close all tabs, were only possible to execute from the File menu, as well as the keyboard shortcut CTRL+Shift+W. —— 5.6 After closing them all (5.5), one playlist remained behind in the "Playlist Editor" — but without its tab — and this playlist was impossible to close by any of the usual means. It only cleared after restarting the app._
—— 6.1 Clicking the "OK" button did not fix the broken track in the playlist. The test ended at step 6. Awaiting response. • |
Sounds good, please capture that in a new issue.
Update of issue #55. As this PR is a small change, you can assume that problem is now present on the default branch. @touwys, it important to try to capture every unique problem or suggestion for improvement in 1 issue as much as possible. That way I can follow up with a fix (PR) for that specific problem. Test results of that specific fix (PR) should be report back into the corresponding PR. If you find new problems, please create new issues. You can refer back in that new issue to specific build, even it was part of PR, no problem. That way a systematic log and approach to address things we want improve will grow. That way we have a clear overview what is still to be done, and what is been solved / implemented. |
If it works better for you write things down in 1 combined report, like the regression test results you posted here, you can also open a new issue for that, and we create and link smaller issues from there. I can make a build for the current default branch if you like, then you know for sure everything you find is a new issue unless we have an existing open issue. Update: Created issue: #64 to capture regression testing. |
@Borewit: My sincere apologies for making a mess of it. Ascribe it to my cluelessness, which is not going to improve any time soon. Therefore, I prefer to stick to what I understand, like writing a single report, and just leave the dissemination of that input up to you to sort out, whichever way you deem fit. You'd be the best judge for that. If you see anything out of place, please do move it to the appropriate location. Thank you for your understanding. |
Herewith a new screenshot of the Playlist Editor, in addition to the two screenshots which were provided yesterday: •
This particular issue also disappeared under the circumstances explained in the aforesaid screenshot. |
7823dc4
to
3a1ee30
Compare
3a1ee30
to
0b43d6b
Compare
Part of release v2.6.0 |
Resolves #56