Regression: Emit notification to check CLI version against client

[cg-jl]

The notification for the check is restored; now a notification is sent regardless of mismatches between LSP & generators. Will not send a notification if generators don't match, since then we don't have a baseline to compare to.

Speculative downloading doesn't make a lot of sense either: download LSP for previous version -> user changes version to match highest version -> download missed. Since # of generators is small then probability of failure is pretty close to 50%.

---

Important

Restores CLI version check notification and refactors version checking logic for robustness.

• Behavior:
  • Restores notification for CLI version check against client, sent regardless of LSP & generator mismatches.
  • Skips notification if generators don't match, lacking a baseline for comparison.
• Functions:
  • Refactors get_common_generator_version() in mod.rs to centralize version checking logic.
  • Introduces send_generator_version() in did_save_text_document.rs to handle version notifications.
• Diagnostics:
  • Updates project_diagnostics() in diagnostics.rs to handle generator version mismatches.
• Misc:
  • Removes speculative downloading logic.

^{This description was created by for e0a91d9. You can customize this summary. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
promptfiddle	Skipped			Sep 2, 2025 3:13pm

[entelligence-ai-pr-reviews]

🔒 Entelligence AI Vulnerability Scanner

✅ No security vulnerabilities found!

Your code passed our comprehensive security analysis.

---

[entelligence-ai-pr-reviews]

LGTM 👍

[github-actions]

🌿 Preview your docs: https://boundary-preview-2256cd3e-1376-4aa0-b200-93aaa6d2bf82.docs.buildwithfern.com

[github-actions]

https://sage-backend-loyzzxcbf-baml.vercel.app

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 95c2364 in 2 minutes and 45 seconds. Click for details.

• Reviewed 306 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. engine/language_server/src/server/api/notifications/did_open.rs:84

• Draft comment:
  Restoring the generator version notification is handled well. Using generator_version.as_ref().ok() ensures that no notification is sent when the version check fails, which aligns with the intended behavior.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply acknowledges that the code is handling a situation correctly, which is not necessary in a code review context.

2. engine/language_server/src/server/api/notifications/did_save_text_document.rs:98

• Draft comment:
  The version-check block combining the runtime, client, and generator versions via chained iterators is clever. Ensure that client_version, when present, always conforms to semver. Also, the extraction of effective_flags appears twice; consider consolidating this to avoid duplicate logic.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment provides a suggestion to consolidate duplicate logic, which is a valid code improvement suggestion. However, the part about ensuring client_version conforms to semver is asking the author to ensure something, which violates the rules. The comment should be edited to remove the part about ensuring semver compliance.

3. engine/language_server/src/server/api/notifications/did_save_text_document.rs:83

• Draft comment:
  The combined version validation (using runtime version, client version, and generator version) is an effective strategy. Just ensure that all parts (especially client_version) are valid semver strings, as this check depends on successful parsing.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and suggests ensuring that all parts are valid semver strings. It doesn't provide a specific code suggestion or point out a potential issue with the code. It violates the rule against making purely informative comments.

4. engine/language_server/src/server/api/notifications/did_save_text_document.rs:79

• Draft comment:
  Typo: "againt" should be "against" in the comment.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about the typo, typos in comments are very minor issues. The meaning is still clear despite the typo. Comments are meant to focus on substantive code issues that need to be fixed, not minor spelling errors that don't affect functionality. The typo could theoretically reduce code readability and professionalism. Documentation quality is important. While documentation quality matters, this is an extremely minor issue that doesn't meaningfully impact understanding. PR comments should focus on more substantial issues. Delete this comment as it focuses on an insignificant typo rather than a meaningful code issue that needs to be fixed.

Workflow ID: wflow_lC5RZFJwcS2IU7CX

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

🌿 Preview your docs: https://boundary-preview-6660c071-d3fe-42fa-b2cc-ad54676c1778.docs.buildwithfern.com

[github-actions]

https://sage-backend-5gm991mzc-baml.vercel.app

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed e0a91d9 in 1 minute and 34 seconds. Click for details.

• Reviewed 46 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. engine/language_server/src/server/api/notifications/did_open.rs:86

• Draft comment:
  Use &locked instead of &*locked for clarity. The dereference is unnecessary if locked implements Deref to the project type.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. engine/language_server/src/server/api/notifications/did_save_text_document.rs:6

• Draft comment:
  Renamed import from BamlProject to Project for consistency. Ensure all usages align with the new type.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. engine/language_server/src/server/api/notifications/did_save_text_document.rs:75

• Draft comment:
  Pass the locked project directly to send_generator_version instead of extracting a separate project reference. This simplifies the code and ensures type consistency with the updated Project alias.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. engine/language_server/src/server/api/notifications/did_save_text_document.rs:78

• Draft comment:
  Typo: In the comment, 'againt' should be corrected to 'against'.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_2ZXRHzfKnHnwXv5C

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[github-actions]

🌿 Preview your docs: https://boundary-preview-842c1020-3209-434b-a749-5544e9be27d9.docs.buildwithfern.com

[github-actions]

https://sage-backend-216lackzt-baml.vercel.app

[github-actions]

🌿 Preview your docs: https://boundary-preview-65f41c02-f17c-4fc8-a2d2-bc7df2ed1a71.docs.buildwithfern.com

[github-actions]

https://sage-backend-e3lcgnbx0-baml.vercel.app

[codecov]

Codecov Report

❌ Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
engine/language_server/src/baml_project/mod.rs	0.00%	41 Missing ⚠️
...server/api/notifications/did_save_text_document.rs	0.00%	28 Missing ⚠️
...ge_server/src/server/api/notifications/did_open.rs	0.00%	3 Missing ⚠️
...gine/language_server/src/server/api/diagnostics.rs	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!