-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira Kanban mode #16
Jira Kanban mode #16
Conversation
…otes into feature/7-jira-multimode
…otes into feature/7-jira-multimode
Would love to see this get merged |
Hey @froznsm this is great stuff! I did some testing and found some bugs and I am working on some improvements. I wanted your opinion on a potential change. To reduce the complexity of having to manually add the column names of the board, I was thinking we could get the board config from the API and just by default get all tasks from that board and then just take the last column as the "final" by default. Then provide an optional comma-separated list of custom "final" columns. This does limit the user since they can't decide which columns to import but I believe that is still better. What do you think? |
Feel free to email me at aaron.buitenwerf@carleton.ca if that is easier than discussing here. |
Some changes I've made so far:
|
So my proposed next change would be this:
|
Thanks for the improvements, fixes and suggestions @BoxThatBeat!
Good stuff!
This approach could certainly work and is more flexible than what I did, so I guess for future proofing this would be better. 👍 from me. |
Alright I'll try that out and see if it works well! By the way, what is the use case to have multiple "final" state statuses? @froznsm |
The ones we use at work are |
Hmm makes sense! |
Hey @froznsm! I made quite a few changes to how this all works and I think it is in a good state. Could you pull the changes and test it out in your use case and let me know how it goes before I merge this? The major change I made was removing all new settings except the toggle between modes. It now determines which files should be in the "completed" folder (renamed from final) by checking for the existence of a field called "resolution" which is Jira's marker for a finished issue. All columns that should mark tasks as complete should have a check mark beside them: You can assign columns this "resolution" designation in settings or with simple Kanban boards it is the "done" state in the workflow. |
@BoxThatBeat I have tested the changes and they do work, as in there are not obvious bugs. Good work! One unfortunate side-effect of your implementation is however, that notes are created for backlog items as well (at least with our board config). I would prefer to only have notes for tickets that currently are in progress, which is why I implemented the setting to make this part configurable. I don't mind it much, so if you feel this way is better, you can merge. |
@froznsm Thanks! Ya I did notice that when I did testing. I wonder if I could just add a boolean setting for whether to include the backlog items or not. I assume the name of the backlog would never change and thus could just be string compared to get rid of it? |
Great idea! A toggle for backlog items would solve my issues and probably work in almost all cases. |
@froznsm Could you try out the new toggle for excluding the backlog I just added? If it works on your system I'll merge it! |
@froznsm Do you plan on testing or should I just merge it? |
sorry for the delay, I just tested it and it works well. Fell free to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
Adds #7.
Some additional changes worth mentioning:
updateCurrentSprint
toupdate
Thorough testing is needed, but it works like my hacked together version now.
All feedback and change requests are welcome :)