Skip to content

A few fixes #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2018
Merged

A few fixes #293

merged 6 commits into from
Nov 4, 2018

Conversation

robertleeplummerjr
Copy link
Contributor

@robertleeplummerjr robertleeplummerjr commented Nov 4, 2018 •
edited
Loading

A GIF or MEME to give some spice of the internet

Description

Motivation and Context

Fixes #262
Fixes #286

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

@robertleeplummerjr
fix:
dce35f3 
Migrate `hiddenSizes` to `hiddenLayers`
Use more stable equation.input
Adjust RNNTimeStep.run's method to have less arguments that are relevant
Implement RNNTimeStep.toFunction()
Remove json as an argument for any recurrent neural network
More maxPredictionLength into net as property
Remove options.keepNetworkIntact from recurrent net
@robertleeplummerjr
fix: Migrate hiddenSizes for crossvalidate
57b92df
@robertleeplummerjr
fix: LeakyRelu and exponential toFunction size for NeuralNetwork
bb9c61b
@robertleeplummerjr
fix: Tests
845d7bd
@robertleeplummerjr
fix: Build
a0e9df3
@robertleeplummerjr
fix: specialIndexes length management for output from run
76435ee 
Created some backward compatibility for hiddenSizes
@robertleeplummerjr
Copy link
Contributor Author

@mrorigo may I get your review on this?

@mrorigo
Copy link

mrorigo commented Nov 4, 2018

Looks good to me, please merge

@robertleeplummerjr robertleeplummerjr merged commit 71864ac into master Nov 4, 2018
@robertleeplummerjr robertleeplummerjr deleted the a-few-fixes branch November 4, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blank output when input string.length > ~100 LSTM/GRU Unable to load Trained Model (LSTMTimeStep) from JSON File

2 participants

@robertleeplummerjr @mrorigo