Skip to content

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Nov 12, 2018

Bug Fix: #299 (#299)

Description

Include specialIndexes when creating DataFormatter from JSON

Motivation and Context

issue

How Has This Been Tested?

Tested locally against examples in the issue.

Note: I did not find any tests for DataFormatter so I am unsure if it is part of the scope of this ticket to add DataFormatter tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

Copy link
Contributor

@robertleeplummerjr robertleeplummerjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@robertleeplummerjr robertleeplummerjr merged commit 59c590e into BrainJS:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromJSON does not work with LSTM
2 participants