Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-1797] - Experiment & Observations import errors (BreedBase) #118

Merged
merged 2 commits into from
May 30, 2023
Merged

[BI-1797] - Experiment & Observations import errors (BreedBase) #118

merged 2 commits into from
May 30, 2023

Conversation

mlm483
Copy link

@mlm483 mlm483 commented May 24, 2023

Description

Here's the bug on Jira.

There were 2 bugs preventing Experiment & Observation imports from DeltaBreed to BreedBase.

  1. BreedBase was only allowing certain characters in Trait (Observation) value field when POSTing via BrAPI, I removed this constraint in lib/CXGN/Phenotypes/ParseUpload/Plugin/Observations.pm. Relates to https://github.com/Breeding-Insight/sgn/pull/117/files.
  2. BreedBase was paginating its response to POST requests to the /studies endpoint, so not all created objects would be contained in the response, which is inconsistent with the BrAPI spec. I changed the pagination behavior to return all created objects, see lib/CXGN/BrAPI/v2/Studies.pm.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@mlm483 mlm483 requested review from a team, davedrp and dmeidlin and removed request for a team May 24, 2023 18:35
@mlm483 mlm483 mentioned this pull request May 24, 2023
Closed
@davedrp
Copy link

davedrp commented May 30, 2023

Passed Developer Testing

@mlm483 mlm483 merged commit 54114ab into develop May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@davedrp davedrp davedrp approved these changes

Assignees

@davedrp davedrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlm483 @davedrp @dmeidlin