Skip to content

fix: added group io logic to shader nodes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

fix: added group io logic to shader nodes #51

merged 1 commit into from
May 23, 2023

Conversation

BrendanParmer
Copy link
Owner

Fixes

  • Error where shader node group inputs and outputs wouldn't be generated

Refactor

  • All group inputs and outputs now share the same logic for creation and settings
  • Renamed node_tree_var to nt_var to make geo_nodes.py consistent with materials.py

@BrendanParmer BrendanParmer added the bug Something isn't working label May 23, 2023
@BrendanParmer BrendanParmer self-assigned this May 23, 2023
@BrendanParmer BrendanParmer linked an issue May 23, 2023 that may be closed by this pull request
Why can't the NodeSocket of the node group be automatically generated? #50
Closed
@BrendanParmer BrendanParmer merged commit 700ae47 into main May 23, 2023
@BrendanParmer BrendanParmer deleted the shader_node_group_fix branch May 23, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BrendanParmer BrendanParmer

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Why can't the NodeSocket of the node group be automatically generated?

1 participant

@BrendanParmer