New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Recipe tool should remove the current equipment #91

Closed
rocketman768 opened this Issue Sep 27, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@rocketman768
Copy link
Member

rocketman768 commented Sep 27, 2015

After the tool is run, it should remove the equipment from the recipe. It does not.

@rocketman768 rocketman768 added the bug label Sep 27, 2015

@rocketman768 rocketman768 added this to the v2.2.0 milestone Sep 27, 2015

@theophae

This comment has been minimized.

Copy link
Contributor

theophae commented Sep 28, 2015

I don't understand why it should do that. If I want to scale my recipe to adapt it to a new efficiency value, why the current equipment should be removed ?

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Sep 28, 2015

That is a good point.

When you are scaling to a different batch size, the recipe batch size no
longer matches the equipment batch size. This means if you rerun the mash
wizard, the volumes and all the other derived calculations are wrong.

Another more elegant solution is to rework the tool to accept a different
equipment as the input so that you can simultaneously scale both efficiency
and volume while replacing the recipe's equipment with the right one.

For now though, the quick fix is to remove the equipment when scaling
volumes. The warning message even tells you this is going to happen.
On Mon, Sep 28, 2015 at 4:25 AM theophae notifications@github.com wrote:

I don't understand why it should do that. If I want to scale my recipe to
adapt it to a new efficiency value, why the current equipment should be
removed ?


Reply to this email directly or view it on GitHub
#91 (comment)
.

@theophae

This comment has been minimized.

Copy link
Contributor

theophae commented Sep 28, 2015

That is a good idea.
And what about automatically execute the mash wizard after these changes. it just needs to take the same mash thickness as input. A simple advisory message to indicate that the mash has been changed seems enough (but not mandatory). I've never understood what it is so difficult to adapt the mash schedule.

@rocketman768

This comment has been minimized.

Copy link
Member

rocketman768 commented Oct 3, 2015

Yeah, executing the mash wizard would be good. I'll make a feature request for this.

@rocketman768 rocketman768 self-assigned this Oct 3, 2015

rocketman768 added a commit that referenced this issue Oct 3, 2015

Merge pull request #101 from rocketman768/bug/scale-recipe-remove-equip
Fixes #91: scale recipe tool should remove equipment

rocketman768 added a commit that referenced this issue Oct 3, 2015

Fixes #91: scale recipe tool should remove equipment
But only if the scaling is by volume, since the volumes will still match if
the scaling is by efficiency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment