Minor improvements to bc-show-eligible #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aster'. Now git bc-show-eligible can be called from repo's subfolders.
mbrt
reviewed
Jul 3, 2018
bin/git-bc-show-eligible
Outdated
| parser = argparse.ArgumentParser(description='Show commits, eligible for cherry-picking') | ||
| parser.add_argument('branch', metavar='BRANCH', help='Name for the branch to check against') | ||
| parser.add_argument('branch', metavar='BRANCH', help='Name for the branch to check against', | ||
| default='master', nargs='?') |
There was a problem hiding this comment.
I think origin/master is better. In case you are on a release branch, you do git pull and check the eligible commits. Many times master and origin/master are misaligned, and the latter seems to be a safer default.
|
|
||
| args = parser.parse_args() | ||
| repo = pygit2.Repository('.') | ||
| repo = pygit2.Repository(top) |
espositocloud
approved these changes
Jul 3, 2018
mbrt
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git bc-show-eligibleBRANCH parameter is now optional, defaults to 'master'.git bc-show-eligiblecan be called from repo's subfolders.