Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eventbody object url validation #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add eventbody object url validation #32

wants to merge 1 commit into from

Conversation

stevenao
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 86.408% when pulling 063d510 on sao/add_eventbody_object_url_validation into 142d69f on master.

mdgbayly
mdgbayly reviewed Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@mdgbayly mdgbayly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this now? Couldn't this cause the same kinds of issues where we break existing clients before they are ready to fix their events to conform to the schema?

Maybe it needs to be deferred until we enforce event schema validation?

@stevenao
Copy link
Contributor Author

I more inclined to defer it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdgbayly mdgbayly mdgbayly left review comments

@xraysaas xraysaas Awaiting requested review from xraysaas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenao @coveralls @mdgbayly