fix(BugSplatManager): unregister logMessageReceived on destruction #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application.logMessageReceived is a static callback handler, which isn't reset when changing scenes or when exiting play mode if domain reloads are not enabled. When destroying the class without unregistering, e.g. due to scene change or existing play mode, the callback will then try to start a coroutine on the destroyed object.
bobbyg603
changed the title
|
LGTM, thank you for your help here @Selmar 🚀 |
bobbyg603
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application.logMessageReceived is a static callback handler, which isn't reset when changing scenes or when exiting play mode if domain reloads are not enabled.
When destroying the class without unregistering, e.g. due to scene change or existing play mode, the callback will then try to start a coroutine on the destroyed object.