Skip to content

fix: symbol uploads for non-android builds in Unity 6 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

fix: symbol uploads for non-android builds in Unity 6 #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed4cfe9
fix: only dump symbols if on Android
slavanomics Apr 14, 2025
df0352f
fix: unity 6 support for android symbols
slavanomics Apr 14, 2025
c66a0ed
Merge branch 'BugSplat-Git:main' into fix-symbols-android-unity-6
slavanomics Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Editor/PostBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@
using UnityEditor;
using UnityEditor.Callbacks;
using UnityEngine;
using Unity.Android.Types;
using BugSplatUnity.Runtime.Client;
using Debug = UnityEngine.Debug;
using BugSplatDotNetStandard.Api;
using BugSplatDotNetStandard.Http;
using Unity.Android.Gradle;
using UserBuildSettings = UnityEditor.Android.UserBuildSettings;

#if UNITY_IOS
using UnityEditor.iOS.Xcode;
Expand Down Expand Up @@ -70,7 +73,7 @@ public static void OnPostprocessBuild(BuildTarget target, string pathToBuiltProj
#if UNITY_EDITOR_WIN
private static void UploadSymbolFilesWin(string pathToBuiltProject, BugSplatOptions options)
{
if (!UserBuildSettings.copyPDBFiles)
if (!UnityEditor.WindowsStandalone.UserBuildSettings.copyPDBFiles)
{
Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Copy PDB files\" is disabled in BuildSettings->Windows.");
return;
Expand Down Expand Up @@ -194,9 +197,9 @@ private static void UploadSymbolsAndroid(string pathToBuiltProject, BugSplatOpti
return;
}

if (EditorUserBuildSettings.androidCreateSymbols == AndroidCreateSymbols.Disabled)
if (UserBuildSettings.DebugSymbols.level == DebugSymbolLevel.None)
{
Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Create symbols.zip\" is not configured in BuildSettings->Android.");
Debug.LogWarning("BugSplat. Skipping symbols uploading since \"Debug Symbols\" is set to None in BuildSettings->Android.");
return;
}

Expand Down Expand Up @@ -284,9 +287,13 @@ private static void UploadSymbols(string artifactsDirPath, string globPattern, B
UseShellExecute = false,
RedirectStandardOutput = true,
Arguments = $"--database {options.Database} --application \"{application}\" --clientId {options.SymbolUploadClientId} --clientSecret {options.SymbolUploadClientSecret} " +
$"--version \"{version}\" --files \"{globPattern}\" --directory \"{artifactsDirPath}\" --dumpSyms"
$"--version \"{version}\" --files \"{globPattern}\" --directory \"{artifactsDirPath}\""
};


if (EditorUserBuildSettings.activeBuildTarget == BuildTarget.Android) {
symUploadProcessInfo.Arguments += " --dumpSyms";
};

var uploadSymProcess = Process.Start(symUploadProcessInfo);
if (uploadSymProcess == null)
{
Expand Down