-
Notifications
You must be signed in to change notification settings - Fork 59
Fixed PlayerFishEvent documentation. Fixes BUKKIT-4975 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9be1783
Fixed PlayerFishEvent documentation. Fixes BUKKIT-4975
fragtastic 1eb1346
Fixed PlayerFishEvent documentation. Fixes BUKKIT-4975
fragtastic 0bb0369
Fixed PlayerFishEvent documentation. Fixes BUKKIT-4975
fragtastic 1dcd22b
Fixed PlayerFishEvent documentation. Fixes BUKKIT-4975
fragtastic 0597b7d
Merged with upstream
fragtastic 493bd85
Fixed doc length
fragtastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,10 +37,12 @@ public PlayerFishEvent(final Player player, final Entity entity, final Fish hook | |
} | ||
|
||
/** | ||
* Gets the entity caught by the player | ||
* Gets the entity caught by the player. | ||
* <p> | ||
* If player has fished successfully, the result may be cast to {@link Item}. | ||
* | ||
* @return Entity caught by the player, null if fishing, bobber has gotten | ||
* stuck in the ground or nothing has been caught | ||
* @return Entity caught by the player, Entity if fishing, and null if bobber | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line still exceeds the 78 character limit. |
||
* has gotten stuck in the ground or nothing has been caught | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should indent wrapped lines by 4 spaces. |
||
*/ | ||
public Entity getCaught() { | ||
return entity; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need a line break here.