Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GlassDoor Country Issue? #122

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Fix GlassDoor Country Issue? #122

merged 4 commits into from
Mar 4, 2024

Conversation

giga-sec
Copy link
Contributor

@giga-sec giga-sec commented Mar 4, 2024

Bossman, I get an error if I input a "two letter country name" even though it is listed in the countries supported.

I haven't tested it yet but is it possible the proposed changes can fix it? Thinkin that the problem is it doesn't accept "two letters"

Bossman, I get error if I input a "two letters country name" even though it is listed in the countries supported. 

I haven't tested it yet but is it possible the proposed changes can fix it? Thinkin that the problem is it doesn't accept "two letters"
@giga-sec
Copy link
Contributor Author

giga-sec commented Mar 4, 2024

Error Code in Console

ValueError: Invalid country string: 'vn'. 

Valid countries are: argentina, australia, austria, bahrain, belgium, brazil, canada, chile, china, colombia, costa rica, czech republic,czechia, denmark, ecuador, egypt, finland, france, germany, greece, hong kong, hungary, india, indonesia, ireland, israel, italy, japan, kuwait, luxembourg, malaysia, mexico, morocco, 
netherlands, new zealand, nigeria, norway, oman, pakistan, panama, peru, philippines, poland, portugal, qatar, romania, saudi arabia, singapore, south africa, south korea, spain, sweden, switzerland, taiwan, thailand, turkey, ukraine, united arab emirates, uk,united kingdom, usa,us,united states, uruguay, venezuela, 
vietnam, usa/ca, worldwide

@cullenwatson
Copy link
Member

good catch. actually just needed to add .com for it as Vietnam uses that for Glassdoor

@cullenwatson cullenwatson merged commit a4f6851 into Bunsly:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants