Get full indeed description #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceyyy
force-pushed
the
fix/indeed-description
branch
from
e1e48df
to
be090de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I really appreciate you for creating this library. It helped me a lot.
One issue I encountered: it never returns the full job description from Indeed. I looked into it and found that the job data url (something like https://www.indeed.com/viewjob?jk=c59d048ac135ae9b&spa=1) returns JSON directly instead of HTML content, therefore bs4 does not handle it and it always falls back to the truncated description.
This PR is a simple patch that parses the JSON instead of using bs4.