Ingest new policy types #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
zaharidichev
force-pushed
the
zd/ingest-new-policy-types
branch
from
6852737 to
7ef110b
Compare
klingerf
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
⭐ Sweet, this is working for me locally! Thanks for putting it together. Just had a few tiny nits.
GET https://10.43.0.1:443/api/v1/namespaces/linkerd/configmaps/linkerd-identity-trust-roots 200 OK in 12 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1beta1 200 OK in 1 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1beta1/servers 200 OK in 7 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1beta1 200 OK in 2 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1beta1/serverauthorizations 200 OK in 5 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1 200 OK in 2 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1/authorizationpolicies 200 OK in 4 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1 200 OK in 1 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1/meshtlsauthentications 200 OK in 5 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1 200 OK in 2 milliseconds
GET https://10.43.0.1:443/apis/policy.linkerd.io/v1alpha1/networkauthentications 200 OK in 6 milliseconds
GET https://10.43.0.1:443/apis/multicluster.linkerd.io/v1alpha1 200 OK in 1 milliseconds
GET https://10.43.0.1:443/apis/multicluster.linkerd.io/v1alpha1/links 200 OK in 3 milliseconds
GET https://10.43.0.1:443/apis/linkerd.io/v1alpha2 200 OK in 1 milliseconds
GET https://10.43.0.1:443/apis/linkerd.io/v1alpha2/serviceprofiles 200 OK in 3 milliseconds
GET https://10.43.0.1:443/apis/split.smi-spec.io/v1alpha1 200 OK in 1 milliseconds
GET https://10.43.0.1:443/apis/split.smi-spec.io/v1alpha1/trafficsplits 200 OK in 4 milliseconds
agent/pkg/k8s/helpers_test.go
Outdated
| case "MeshTLSAuthentication": | ||
| l5dObjects = append(l5dObjects, obj) | ||
| case "NetworkAuthentication": | ||
| l5dObjects = append(l5dObjects, obj) |
There was a problem hiding this comment.
TIOLI you could use multiple values in one case to shorten this up a bit. Something like:
switch obj.GetObjectKind().GroupVersionKind().Kind {
case "ServiceProfile", "ServerAuthorization", "Server", "AuthorizationPolicy",
"MeshTLSAuthentication", "NetworkAuthentication", "Link":
l5dObjects = append(l5dObjects, obj)
case "TrafficSplit":
tsObjs = append(tsObjs, obj)
default:
objs = append(objs, obj)
}
proto/buoyant-cloud-api.proto
Outdated
| message AuthPolicyInfo { | ||
| repeated Server servers = 1; | ||
| repeated ServerAuthorization server_authorizations = 2; | ||
| repeated AuthorizationPolicy authorization_policies = 3; | ||
| repeated MeshTLSAuthentication mesh_tls_authenticatios = 4; |
There was a problem hiding this comment.
Typo here -- mesh_tls_authenticatios => mesh_tls_authentications
agent/pkg/handler/linkerd_info.go
Outdated
| Servers: servers, | ||
| ServerAuthorizations: serverAuths, | ||
| AuthorizationPolicies: authPolicies, | ||
| MeshTlsAuthenticatios: meshTlsAuthentications, |
There was a problem hiding this comment.
Once you update the protobuf, this should be MeshTlsAuthentications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the ingestion of the new Linkerd policy types that are outlined in linkerd/linkerd2#7709
Signed-off-by: Zahari Dichev zaharidichev@gmail.com