Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding license info #30

Closed
erickt opened this issue Jan 16, 2020 · 1 comment
Closed

Adding license info #30

erickt opened this issue Jan 16, 2020 · 1 comment

Comments

@erickt
Copy link
Contributor

erickt commented Jan 16, 2020

Hello @BurntSushi! Would it be possible to add some more license info?

  • In src/unicode, it appears that you've extracted some data from unicode.
  • In src/utf8.rs, you mention that code is based off of https://bjoern.hoehrmann.de/utf-8/decoder/dfa/, but don't reference what license that code falls under.

Could you add these licenses to the crate, and reference this in the Cargo.toml / readme? Thanks so much!
@BurntSushi
Copy link
Owner

BurntSushi commented Jan 16, 2020 •
edited
Loading

@erickt The Unicode data is only used in tests. Otherwise, all Unicode data comes in the form of finite state machines generated by ucd-generate. Regardless, I've added a note about this in the README.

As for src/utf8.rs, I feel that the comment there is enough. I do not agree that the copyright of src/utf8.rs falls under the copyright of https://bjoern.hoehrmann.de/utf-8/decoder/dfa/.

erickt added a commit to erickt/bstr that referenced this issue Jan 21, 2020
@erickt
Exclude src/unicode/data from package
e7a0b23 
According to this [comment], the unicode data in src/unicode/data is only
used by tests, therefore are unnecessary in the published package.

[comment]: BurntSushi#30 (comment)
@erickt erickt mentioned this issue Jan 21, 2020
Closed
erickt added a commit to erickt/bstr that referenced this issue Jan 22, 2020
@erickt
Add unicode license for src/unicode/data
899ddc1 
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex,
This adds the unicode license for the test unicode data in
`src/unicode/data`.

[patch]: rust-lang/regex#535,
@erickt erickt mentioned this issue Jan 22, 2020
Merged
erickt added a commit to erickt/bstr that referenced this issue Jan 22, 2020
@erickt
Add unicode license for src/unicode/data
017cb1a 
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex,
this adds the unicode license for the test unicode data in
`src/unicode/data`.

[patch]: rust-lang/regex#535,
BurntSushi pushed a commit that referenced this issue Jan 22, 2020
@erickt @BurntSushi
legal: add unicode license for src/unicode/data
2848647 
As a followup to #30, and analogous to this
rust-lang/regex#535 in rust-lang/regex,
this adds the unicode license for the test unicode data in
`src/unicode/data`.

PR #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickt @BurntSushi