Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: add the unicode license for unicode-tables #535

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

cgonyeo
Copy link
Contributor

@cgonyeo cgonyeo commented Nov 7, 2018

Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

cc @BurntSushi

Fixes #530

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@cgonyeo
Copy link
Contributor Author

cgonyeo commented Nov 7, 2018

Oh, I should also update the Cargo.toml. Let me update this before it merges.

regex-syntax/Cargo.toml Outdated Show resolved Hide resolved
@BurntSushi
Copy link
Member

Thanks! I imagine other crates in the Rust ecosystem may want to do the same. cc @SimonSapin @Manishearth

Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

Fixes rust-lang#530
@BurntSushi
Copy link
Member

Thanks again! This change is now on crates.io in regex-syntax 0.6.3.

BurntSushi pushed a commit that referenced this pull request Dec 1, 2018
Following the style to the nearby links to LICENSE-APACHE
and LICENSE_MIT, the link to LICENSE-UNICODE was placed
after an opening parenthesis, but the closing parenthesis was
missing.

See also #535

PR #536
erickt added a commit to erickt/bstr that referenced this pull request Jan 22, 2020
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex,
This adds the unicode license for the test unicode data in
`src/unicode/data`.

[patch]: rust-lang/regex#535,
erickt added a commit to erickt/bstr that referenced this pull request Jan 22, 2020
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex,
this adds the unicode license for the test unicode data in
`src/unicode/data`.

[patch]: rust-lang/regex#535,
BurntSushi pushed a commit to BurntSushi/bstr that referenced this pull request Jan 22, 2020
As a followup to #30, and analogous to this
rust-lang/regex#535 in rust-lang/regex,
this adds the unicode license for the test unicode data in
`src/unicode/data`.

PR #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants