-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
license: add the unicode license for unicode-tables #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Oh, I should also update the Cargo.toml. Let me update this before it merges. |
BurntSushi
reviewed
Nov 7, 2018
Thanks! I imagine other crates in the Rust ecosystem may want to do the same. cc @SimonSapin @Manishearth |
Add the Unicode license to the unicode-tables directory, as the data there comes from the Unicode Consortium. Fixes rust-lang#530
Thanks again! This change is now on crates.io in |
erickt
added a commit
to erickt/bstr
that referenced
this pull request
Jan 22, 2020
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex, This adds the unicode license for the test unicode data in `src/unicode/data`. [patch]: rust-lang/regex#535,
erickt
added a commit
to erickt/bstr
that referenced
this pull request
Jan 22, 2020
As a followup to BurntSushi#30, and analogous to this [patch] in rust-lang/regex, this adds the unicode license for the test unicode data in `src/unicode/data`. [patch]: rust-lang/regex#535,
BurntSushi
pushed a commit
to BurntSushi/bstr
that referenced
this pull request
Jan 22, 2020
As a followup to #30, and analogous to this rust-lang/regex#535 in rust-lang/regex, this adds the unicode license for the test unicode data in `src/unicode/data`. PR #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.
cc @BurntSushi
Fixes #530