Skip to content

Conversation

doug-martin
Copy link
Contributor

@doug-martin doug-martin commented May 15, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Have you added tests for the new feature
  2. Does your submission pass tests?
  3. Have you lint your code locally prior to submission?
  4. Have you updated the docs?
    • If you added new parsing or formatting options have you added them to the docs?
    • If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coveralls
Copy link

coveralls commented May 15, 2020

Pull Request Test Coverage Report for Build 106021653

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.975%

Totals Coverage Status
Change from base Build 106015928: 0.0%
Covered Lines: 728
Relevant Lines: 745

💛 - Coveralls

@doug-martin doug-martin merged commit cbef781 into master May 15, 2020
@doug-martin doug-martin deleted the issue345 branch May 15, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants