-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moment map generation information to FITS header #1091
Conversation
@markccchiang quick questions, does this new info exist in the header of the in-memory moment images (the image auto appended to carta after the moment image is generated)? I am not sure where I can locate this new info. 🤔 I suggest we refine the extra moment generation info as the following:
|
@kswang1029 as for the moment region info about pixel coordinates. Does it mean the control points of regions (e.g., point, rectangle, polygon..)? |
yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@markccchiang just realized that the polarization info is missing. Could you add it too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding polarization info. It works with usual Stokes. Now CARTA supports computed polarization quantities too such as polarized intensity, angle, etc, so when these are selected, the displayed text is unknown.
HISTORY = / Stokes: Unknown
I suggest we call show this as
Polarization: Stokes Q
Polarization: Fractional polarized intensity
Polarization: XY
Please confirm are the full name of the computed stokes correct? Ptotal: Total linearly polarized intensity |
@markccchiang please consider Ptotal: total polarization intensity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! 👍
Closes #1024. Adding some information to the FITS header history about moment map generation. As shown below: