Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moment map generation information to FITS header #1091

Merged
merged 16 commits into from
May 9, 2022

Conversation

markccchiang
Copy link
Contributor

@markccchiang markccchiang commented Apr 28, 2022

Closes #1024. Adding some information to the FITS header history about moment map generation. As shown below:

截圖 2022-04-28 下午1 22 13

@kswang1029
Copy link
Contributor

kswang1029 commented May 2, 2022

@markccchiang quick questions, does this new info exist in the header of the in-memory moment images (the image auto appended to carta after the moment image is generated)? I am not sure where I can locate this new info. 🤔

I suggest we refine the extra moment generation info as the following:

  1. add a string like CARTA MOMENT MAP GENERATOR LOG before add extra info from CARTA
  2. the extra info should include
    a. the input image for moment map generation
    b. region info (pixel coordinate should be fine)
    c. spectral range (channel, freq, and velocity). This is included already. 👍
    d. mask info

@markccchiang
Copy link
Contributor Author

@kswang1029 as for the moment region info about pixel coordinates. Does it mean the control points of regions (e.g., point, rectangle, polygon..)?

@kswang1029
Copy link
Contributor

@kswang1029 as for the moment region info about pixel coordinates. Does it mean the control points of regions (e.g., point, rectangle, polygon..)?

yes.

@markccchiang
Copy link
Contributor Author

Now the new moment map generation info from the header of moment images would look like this:

截圖 2022-05-03 下午1 55 45

@kswang1029
Copy link
Contributor

Now the new moment map generation info from the header of moment images would look like this:

截圖 2022-05-03 下午1 55 45

this works nicely! Could you add region type too? Also we need rotation angle be part of the info.

HISTORY = / Region control points: [402.9424, 374.0267], [242.3408, 294.6644]

I suggest the format like this (please refer to the header of the exported tsv file from the spectral profiler)

rotbox[[402.942341pix, 374.026678pix], [242.340792pix, 294.664372pix], 0.000000deg]

@markccchiang markccchiang marked this pull request as ready for review May 4, 2022 02:10
@kswang1029 kswang1029 self-requested a review May 4, 2022 03:14
Copy link
Contributor

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kswang1029
Copy link
Contributor

@markccchiang just realized that the polarization info is missing. Could you add it too?

@kswang1029 kswang1029 self-requested a review May 5, 2022 14:03
Copy link
Contributor

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding polarization info. It works with usual Stokes. Now CARTA supports computed polarization quantities too such as polarized intensity, angle, etc, so when these are selected, the displayed text is unknown.

HISTORY = / Stokes: Unknown

I suggest we call show this as

Polarization: Stokes Q
Polarization: Fractional polarized intensity
Polarization: XY

@markccchiang
Copy link
Contributor Author

I suggest we call show this as

Polarization: Stokes Q
Polarization: Fractional polarized intensity
Polarization: XY

Please confirm are the full name of the computed stokes correct?

Ptotal: Total linearly polarized intensity
Plinear: Linearly polarized intensity
PFtotal: Total fractional linear polarization
PFlinear: Fractional linear polarization
Pangle: Linearly polarized angle

@kswang1029
Copy link
Contributor

@markccchiang please consider

Ptotal: total polarization intensity
Plinear: linear polarization intensity
PFtotal: fractional total polarization intensity
PFlinear: fractional linear polarization intensity
Pangle: polarization angle

@kswang1029 kswang1029 self-requested a review May 7, 2022 08:02
Copy link
Contributor

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! 👍

@confluence confluence self-assigned this May 9, 2022
src/Frame/Frame.cc Outdated Show resolved Hide resolved
@confluence confluence merged commit ddeaff8 into dev May 9, 2022
@confluence confluence deleted the mark/1024_add_moment_map_gen_info branch May 9, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include moment map generation information
3 participants