Mark/add axes numbers #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@markccchiang don't forget the changelog and the index! (I forget this in my last PR!) |
… mark/add_axes_numbers
… mark/add_axes_numbers
confluence
requested changes
Mar 13, 2023
docs/src/index.rst
Outdated
| :ICD Version Integer: 28 | ||
| :CARTA Target: Version 4.0 | ||
| :CARTA Target: Version 5.0 |
There was a problem hiding this comment.
I think you replaced this accidentally.
shared/defs.proto
Outdated
Comment on lines
65
to
68
| // Direction X axis number | ||
| sfixed32 dir_x = 1; | ||
| // Direction Y axis number | ||
| sfixed32 dir_y = 2; |
There was a problem hiding this comment.
I would change "Direction" to "Spatial" here.
There was a problem hiding this comment.
I would also rename dir_x and dir_y to spatial_x and spatial_y.
confluence
requested changes
Mar 13, 2023
shared/defs.proto
Outdated
Comment on lines
65
to
68
| // Direction X axis number | ||
| sfixed32 dir_x = 1; | ||
| // Direction Y axis number | ||
| sfixed32 dir_y = 2; |
There was a problem hiding this comment.
I would also rename dir_x and dir_y to spatial_x and spatial_y.
confluence
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new sub-message
AxesNumbersin the messageFileInfoExtendedand passes it to the frontend. So the frontend can decide which axes to be rendered (axis number is 1 or 2). And which is the depth axis (axis number > 2) for non-stokes axis. This is for the backend PR 1194 and the frontend PR 2011.